Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy-pr-bot #742

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Use copy-pr-bot #742

merged 1 commit into from
Sep 5, 2023

Conversation

ajschmidt8
Copy link
Contributor

This PR replaces the copy_prs functionality from the ops-bot with the new dedicated copy-pr-bot GitHub application.

Thorough documentation for the new copy-pr-bot application can be viewed below.

Important: copy-pr-bot enforces signed commits. If an organization member opens a PR that contains unsigned commits, it will be deemed untrusted and therefore require an /ok to test comment. See the GitHub docs here for information on how to set up commit signing.

Any time a PR is deemed untrusted, it will receive a comment that looks like this: rapidsai/ci-imgs#63 (comment).

Every subsequent commit on an untrusted PR will require an additional /ok to test comment.

Any existing PRs that have unsigned commits after this change is merged will require an /ok to test comment for each subsequent commit or the PR can be rebased to sign the unsigned commits as mentioned in the docs here: https://docs.gha-runners.nvidia.com/cpr/contributors.

This information is all included on the documentation page linked above.

I've skipped CI on this PR since it's not a change that is tested.

[skip ci]

This PR replaces the `copy_prs` functionality from the `ops-bot` with the new dedicated `copy-pr-bot` GitHub application.

Thorough documentation for the new `copy-pr-bot` application can be viewed below.

- https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/

**Important**: `copy-pr-bot` enforces signed commits. If an organization member opens a PR that contains unsigned commits, it will be deemed untrusted and therefore require an `/ok to test` comment. See the GitHub docs [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) for information on how to set up commit signing.

Any time a PR is deemed untrusted, it will receive a comment that looks like this: rapidsai/ci-imgs#63 (comment).

Every subsequent commit on an untrusted PR will require an additional `/ok to test` comment.

Any existing PRs that have unsigned commits after this change is merged will require an `/ok to test` comment for each subsequent commit _or_ the PR can be rebased to sign the unsigned commits as mentioned in the docs here:
https://docs.gha-runners.nvidia.com/cpr/contributors.

This information is all included on the documentation page linked above.

_I've skipped CI on this PR since it's not a change that is tested._

[skip ci]
@rapids-bot
Copy link

rapids-bot bot commented Aug 29, 2023

Pull requests from external contributors require approval from a NVIDIA-Merlin organization member with write permissions or greater before CI can begin.

@ajschmidt8
Copy link
Contributor Author

Keeping this PR as a draft until I've had a chance to coordinate with Julio or Adam to get this new application installed on the NVIDIA-Merlin organization.

@jperez999 jperez999 marked this pull request as ready for review September 5, 2023 17:05
@jperez999 jperez999 merged commit 30f0946 into NVIDIA-Merlin:main Sep 5, 2023
@ajschmidt8 ajschmidt8 deleted the copy-pr branch September 5, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants